GLSP-1636: Remove yarn-compatibility workarounds for pnpm migration#60
Merged
Merged
Conversation
Now that all GLSP repos are migrated to pnpm, drop the temporary workarounds that bridged the mid-migration yarn remainders: - Remove the yarn.lock detection (isYarnRepo) and always launch the theia binary via `pnpm exec` in the e2e web-server config - Stop pinning cloned yarn repos' packageManager field in setup.ts - Drop the nx.json workaround for the cloned glsp-vscode-integration repo, no longer lerna-based after its pnpm migration Part of: eclipse-glsp/glsp#1636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The pnpm migration introduced temporary workarounds to stay compatible with
GLSP repos that were still yarn-based mid-migration. Now that all repos are on
pnpm, these are no longer needed:
yarn.lockdetection (isYarnRepo) and always launch thetheiabinary via
pnpm execin the e2e web-server configpackageManagerfield insetup.tsnx.jsonworkaround for the clonedglsp-vscode-integrationrepo,no longer lerna-based after its pnpm migration
Part of: eclipse-glsp/glsp#1636
How to test
pnpm build, lint, format, and header checks pass locally/test theia) and confirm the web-server launchesagainst the freshly cloned, pnpm-based integration repos
Follow-ups
Changelog